Bug 98085

Summary: IndexedDB: remove autogenerated objectStore/index id code
Product: WebKit Reporter: Alec Flett <alecflett>
Component: WebCore Misc.Assignee: Alec Flett <alecflett>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, dgrogan, fishd, jamesr, jsbell, peter+ews, tkent+wkapi, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 97834    
Bug Blocks: 98682    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alec Flett
Reported 2012-10-01 15:48:16 PDT
After we land bug 97834, we'll need to remove support for autogenerated objectStore and index database ids.
Attachments
Patch (31.05 KB, patch)
2012-10-08 13:22 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (40.13 KB, patch)
2012-10-08 14:29 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Patch (39.31 KB, patch)
2012-10-08 14:46 PDT, Alec Flett 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alec Flett
Comment 1 2012-10-08 13:22:44 PDT
Created attachment 167596 [details] Patch
Alec Flett
Comment 2 2012-10-08 13:23:20 PDT
jsbell@ - quick once-over? mostly code removal.
Alec Flett
Comment 3 2012-10-08 13:34:39 PDT
jsbell@ - wait ignore that there were a few more things I just figured out I could remove.
WebKit Review Bot
Comment 4 2012-10-08 14:07:11 PDT
Comment on attachment 167596 [details] Patch Attachment 167596 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/14197024
Joshua Bell
Comment 5 2012-10-08 14:13:12 PDT
Comment on attachment 167596 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167596&action=review lgtm, one nit. > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:-628 > - ASSERT(maxIndexIds.size() == ids.size()); Why is this being removed?
Peter Beverloo (cr-android ews)
Comment 6 2012-10-08 14:21:05 PDT
Comment on attachment 167596 [details] Patch Attachment 167596 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/14228336
Alec Flett
Comment 7 2012-10-08 14:29:29 PDT
Created attachment 167610 [details] Patch
WebKit Review Bot
Comment 8 2012-10-08 14:32:45 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Alec Flett
Comment 9 2012-10-08 14:33:32 PDT
ok this is ready - turns out the chromium side wasn't calling into the old API, thus could be removed in one shot. jsbell@ - ready for review. even more code/scaffolding removal than the previous patch.
Joshua Bell
Comment 10 2012-10-08 14:42:04 PDT
Comment on attachment 167610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=167610&action=review Still lgtm, w/ nits. > Source/WebCore/ChangeLog:-1555 > - Accidental whitespace removal? > Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:-628 > - ASSERT(maxIndexIds.size() == ids.size()); Still want this assert?
Alec Flett
Comment 11 2012-10-08 14:46:59 PDT
Created attachment 167619 [details] Patch
Alec Flett
Comment 12 2012-10-08 14:47:54 PDT
tony@ - r? abarth@ - r? for chromium glue (just code removal)
WebKit Review Bot
Comment 13 2012-10-08 18:17:55 PDT
Comment on attachment 167619 [details] Patch Clearing flags on attachment: 167619 Committed r130708: <http://trac.webkit.org/changeset/130708>
WebKit Review Bot
Comment 14 2012-10-08 18:17:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.