Bug 232619

Summary:

perspective() <= 1px should be clamped to 1px

Product:

WebKit

Reporter:

Martin Robinson <mrobinson>

Component:

CSS

Assignee:

Martin Robinson <mrobinson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

232618

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

Martin Robinson

Reported 2021-11-02 05:09:18 PDT

There are some relevant W3C issues for this: * https://github.com/w3c/csswg-drafts/issues/413 * https://github.com/w3c/csswg-drafts/issues/6320 * https://github.com/w3c/csswg-drafts/issues/6346

Attachments
Patch (32.66 KB, patch) 2021-12-02 09:45 PST, Martin Robinson	no flags	Details Formatted Diff Diff
Patch (34.97 KB, patch) 2021-12-03 07:20 PST, Martin Robinson	no flags	Details Formatted Diff Diff
Patch (23.33 KB, patch) 2021-12-06 05:11 PST, Martin Robinson	no flags	Details Formatted Diff Diff
Patch (23.32 KB, patch) 2021-12-06 23:36 PST, Martin Robinson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-11-09 04:10:20 PST

<rdar://problem/85197362>

Martin Robinson

Comment 2 2021-12-02 09:45:56 PST

Created attachment 445729 [details] Patch

Simon Fraser (smfr)

Comment 3 2021-12-02 10:42:17 PST

Comment on attachment 445729 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445729&action=review > Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h:68 > + return m_interoperabilityState == TransformInteropabilityEnabled ? std::max(1.0f, returnValue) : returnValue; Not sure if it's worth plumbing ScriptExecutionContext all the way through just to check the setting here. I bet we could do this without undue compat risk.

Martin Robinson

Comment 4 2021-12-03 07:20:30 PST

Created attachment 445848 [details] Patch

Martin Robinson

Comment 5 2021-12-06 05:11:07 PST

Created attachment 446028 [details] Patch

Martin Robinson

Comment 6 2021-12-06 05:30:43 PST

(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 445729 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=445729&action=review > > > Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h:68 > > + return m_interoperabilityState == TransformInteropabilityEnabled ? std::max(1.0f, returnValue) : returnValue; > > Not sure if it's worth plumbing ScriptExecutionContext all the way through > just to check the setting here. I bet we could do this without undue compat > risk. Thanks for the review. I've updated the patch to remove the plumbing and also updated the WebKit-specific tests that were failing.

Martin Robinson

Comment 7 2021-12-06 23:36:02 PST

Created attachment 446131 [details] Patch

EWS

Comment 8 2021-12-07 00:27:19 PST

Committed r286591 (?): <https://commits.webkit.org/r286591> All reviewed patches have been landed. Closing bug and clearing flags on attachment 446131 [details].

Note You need to log in before you can comment on or make changes to this bug.