Bug 232618

Summary: Add a runtime flag to enable CSS Transforms Level 2 spec compliant behavior
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: CSSAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 229141, 232619    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Martin Robinson
Reported 2021-11-02 04:57:46 PDT
Some aspects of the CSS Transforms Level 2 specification break backward compatibility. Having a runtime flag for this behavior will allowing experimenting with turning it on in order to test compatibility.
Attachments
Patch (3.78 KB, patch)
2021-11-04 11:29 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (1.53 KB, patch)
2021-11-30 05:18 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch (1.52 KB, patch)
2021-12-01 02:08 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2021-11-04 11:29:02 PDT
Created attachment 443325 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-11-09 03:58:22 PST
<rdar://problem/85196916>
Simon Fraser (smfr)
Comment 3 2021-11-29 08:41:01 PST
Comment on attachment 443325 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443325&action=review r- to switch to a setting. > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1325 > + humanReadableDescription: "Enable Transforms Level 2 spec compliant behavior that is backwards incompatble" "incompatble". I think we can come up with a better name/description. Maybe "CSS 3D Transform Interoperability"? > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1326 > + webcoreBinding: RuntimeEnabledFeatures We don't use RuntimeEnabledFeatures any more.
Martin Robinson
Comment 4 2021-11-30 05:18:46 PST
Created attachment 445409 [details] Patch
Martin Robinson
Comment 5 2021-11-30 05:33:52 PST
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 443325 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443325&action=review > > r- to switch to a setting. Thanks for the review! I've uploaded a new version of the change that addresses your comments. > > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1325 > > + humanReadableDescription: "Enable Transforms Level 2 spec compliant behavior that is backwards incompatble" > > "incompatble". > > I think we can come up with a better name/description. Maybe "CSS 3D > Transform Interoperability"? I've improved the description and the naming along the lines you suggested. > > > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:1326 > > + webcoreBinding: RuntimeEnabledFeatures > > We don't use RuntimeEnabledFeatures any more. Ah, I wasn't aware of this! I've converted this to a setting. It will require piping things through a bit (since it seems that settings are accessed through the Document), but this isn't a bit deal.
Simon Fraser (smfr)
Comment 6 2021-11-30 09:47:00 PST
Comment on attachment 445409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445409&action=review > Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:170 > + humanReadableDescription: "Enable 3D transform behavior that specification-compliant but backwards incompatible" that is specification-compliant
Martin Robinson
Comment 7 2021-12-01 02:08:09 PST
Created attachment 445542 [details] Patch
EWS
Comment 8 2021-12-01 02:53:48 PST
Committed r286357 (244716@main): <https://commits.webkit.org/244716@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445542 [details].
Note You need to log in before you can comment on or make changes to this bug.