Bug 20983

Summary: ArgumentsData should have some room to allocate some extra arguments inline
Product: WebKit Reporter: Cameron Zwarich (cpst) <zwarich>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 20813    
Attachments:
Description Flags
patch zwarich: review+

Cameron Zwarich (cpst)
Reported 2008-09-21 21:16:12 PDT
Whenever there are extra arguments, we allocate memory for them in the constructor of the Arguments object and free them in the destructor. This is especially bad in any code that uses the Prototype framework (including the V8 Raytrace test). We should figure out a good number of arguments for which to reserve inline storage and eliminate this hit in the common case. I am assigning this to myself.
Attachments
patch (5.67 KB, patch)
2008-09-22 21:50 PDT, Darin Adler 		zwarich: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2008-09-22 13:51:31 PDT
Geoff is pretty sure that the common number of extra arguments is 2. So inline capacity for, say, 3, should be enough! Geoff also pointed out that we could have a special case for when there are no declared parameters at all. I don't remember his specific ideas.
Darin Adler
Comment 2 2008-09-22 21:36:14 PDT
Cameron, sorry, I got impatient and did this one.
Darin Adler
Comment 3 2008-09-22 21:50:34 PDT
Created attachment 23693 [details] patch
Cameron Zwarich (cpst)
Comment 4 2008-09-22 21:55:18 PDT
Comment on attachment 23693 [details] patch r=me, assuming it passes all tests
Darin Adler
Comment 5 2008-09-22 21:56:31 PDT
http://trac.webkit.org/changeset/36792
Note You need to log in before you can comment on or make changes to this bug.