Bug 143135

Summary:

Python SCM should be able to retrieve untracked files - Add GIT support

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Tools / Tests

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, ap, bfulgham, commit-queue, glenn, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

143314, 152536, 152546

Bug Blocks:

142400, 143093

Attachments:

Description	Flags
Patch	none
Landing with additional test	none
Rebased version	none
Fix bug title in ChangeLog for landing	none

youenn fablet

Reported 2015-03-27 10:30:21 PDT

AS illustrated by bug 142400 and 143093, it might be convenient to get untracked files from SCM, either including ignored files or not.

Attachments
Patch (6.35 KB, patch) 2015-03-27 10:42 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Landing with additional test (6.55 KB, patch) 2015-03-30 23:43 PDT, youenn fablet	no flags	Details Formatted Diff Diff
Rebased version (3.30 KB, patch) 2016-01-02 05:52 PST, youenn fablet	no flags	Details Formatted Diff Diff
Fix bug title in ChangeLog for landing (3.24 KB, patch) 2016-01-06 01:16 PST, youenn fablet	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

youenn fablet

Comment 1 2015-03-27 10:42:57 PDT

Created attachment 249582 [details] Patch

Ryosuke Niwa

Comment 2 2015-03-30 19:22:39 PDT

Comment on attachment 249582 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=249582&action=review > Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py:325 > + # FIXME: Validate that untracked_files do not change with .gitignore/svn:ignore if include_ignored_files is set to True. Please add a test case for that. You can, for example, add .pyc file.

youenn fablet

Comment 3 2015-03-30 23:43:20 PDT

Created attachment 249802 [details] Landing with additional test

WebKit Commit Bot

Comment 4 2015-03-31 00:34:59 PDT

Comment on attachment 249802 [details] Landing with additional test Clearing flags on attachment: 249802 Committed r182174: <http://trac.webkit.org/changeset/182174>

WebKit Commit Bot

Comment 5 2015-03-31 00:35:03 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 6 2015-04-01 12:16:39 PDT

Re-opened since this is blocked by bug 143314

youenn fablet

Comment 7 2015-12-17 12:51:31 PST

As shown in bug 152257, it would be handy to fix that. Last time it was landed, it broke windows builds for unobvious reasons. Is it ok to try relanding it?

Alex Christensen

Comment 8 2015-12-17 12:58:35 PST

If it broke the Windows build, we should not re-land the same patch, or else it will definitely break the Windows build again.

youenn fablet

Comment 9 2015-12-17 13:04:08 PST

(In reply to comment #8) > If it broke the Windows build, we should not re-land the same patch, or else > it will definitely break the Windows build again. It happened apparently due to a specific version of cygwin. Any chance for a change on cygwin usage/cygwin version used on windows bots since April?

Brent Fulgham

Comment 10 2015-12-17 13:11:43 PST

I believe it broke Windows EWS for reasons I was not able to figure out. I don't think we want to risk breaking EWS again, unless we understand why it broke in the first place.

youenn fablet

Comment 11 2015-12-17 13:31:03 PST

(In reply to comment #10) > I believe it broke Windows EWS for reasons I was not able to figure out. I > don't think we want to risk breaking EWS again, unless we understand why it > broke in the first place. IIRC, this caused issues in the parsing of python files. I was thinking of relanding this patch as several smaller bits: - scm generic changes - svn changes - git changes, potentially removing the regular expression stuff (root issue maybe?)

Brent Fulgham

Comment 12 2015-12-17 13:44:43 PST

(In reply to comment #11) > (In reply to comment #10) > > I believe it broke Windows EWS for reasons I was not able to figure out. I > > don't think we want to risk breaking EWS again, unless we understand why it > > broke in the first place. > > IIRC, this caused issues in the parsing of python files. > I was thinking of relanding this patch as several smaller bits: > - scm generic changes > - svn changes > - git changes, potentially removing the regular expression stuff (root issue > maybe?) Yes -- I would be in favor of this approach.

youenn fablet

Comment 13 2016-01-02 05:52:42 PST

Created attachment 268103 [details] Rebased version

youenn fablet

Comment 14 2016-01-05 11:52:46 PST

(In reply to comment #13) > Created attachment 268103 [details] > Rebased version Thanks for the review. The win bots are not yet settled on this patch but this looks unrelated to this patch. And the win bots that tried running this patch seem to continue processing patches. I plan to land this patch tomorrow.

youenn fablet

Comment 15 2016-01-06 01:16:49 PST

Created attachment 268361 [details] Fix bug title in ChangeLog for landing

WebKit Commit Bot

Comment 16 2016-01-06 02:15:32 PST

Comment on attachment 268361 [details] Fix bug title in ChangeLog for landing Clearing flags on attachment: 268361 Committed r194634: <http://trac.webkit.org/changeset/194634>

WebKit Commit Bot

Comment 17 2016-01-06 02:15:38 PST

All reviewed patches have been landed. Closing bug.

Brent Fulgham

Comment 18 2016-01-06 08:48:12 PST

All Windows build bots and EWS units are functioning fine with this patch.

Note You need to log in before you can comment on or make changes to this bug.