Bug 100200

Summary: [chromium] Respect image orientation in image dragging code
Product: WebKit Reporter: Nico Weber <thakis>
Component: New BugsAssignee: Nico Weber <thakis>
Status: RESOLVED FIXED    
Severity: Normal CC: tony, varunjain, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100191    
Attachments:
Description Flags
Patch
none
Patch none

Nico Weber
Reported 2012-10-23 22:41:16 PDT
[chromium] Respect image orientation in image dragging code
Attachments
Patch (3.80 KB, patch)
2012-10-23 22:42 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Patch (3.79 KB, patch)
2012-10-24 09:12 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2012-10-23 22:42:50 PDT
Created attachment 170318 [details] Patch
Nico Weber
Comment 2 2012-10-23 22:46:42 PDT
Looks like Tony reviewed code in this area recently, and Varun wrote code in this area recently. Please take a look. (Varun: image sizes are in pixels, so I don't need to do anything special for this to be correct in hidpi, is that right?)
Nico Weber
Comment 3 2012-10-24 09:12:59 PDT
Created attachment 170412 [details] Patch
Varun Jain
Comment 4 2012-10-24 10:49:38 PDT
(In reply to comment #2) > Looks like Tony reviewed code in this area recently, and Varun wrote code in this area recently. Please take a look. > > (Varun: image sizes are in pixels, so I don't need to do anything special for this to be correct in hidpi, is that right?) Yes. The device scale factor is applied later in DragClientImpl. So I think this should just work for hidpi.
WebKit Review Bot
Comment 5 2012-10-24 11:03:01 PDT
Comment on attachment 170412 [details] Patch Clearing flags on attachment: 170412 Committed r132374: <http://trac.webkit.org/changeset/132374>
WebKit Review Bot
Comment 6 2012-10-24 11:03:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.