Attachment #105702 for bug #62915

View Details Raw Unified Return to Bug 62915



2011-08-30  Kulanthaivel Palanichamy  <kulanthaivel@codeaurora.org>

        Focus ring is rendered incorrectly for a block with -webkit-writing-mode
        https://bugs.webkit.org/show_bug.cgi?id=62915

        Reviewed by NOBODY (OOPS!).

        * fast/css/focus-ring-multiline-writingmode-vertical.html: Added.
        * platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
        * platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.

2011-08-29  Kenji Imasaki  <imasaki@chromium.org>

        [Chromium] Added new rebaselines for media/media-document-audio-repaint.



<html>
<head>
<script>
window.onload = function()
{
    document.getElementById("multiline").focus();
}
</script>
</head>
<body>
<div id="multiline" style="-webkit-writing-mode: vertical-rl; width: 10em; height: 10em;" contenteditable>
Assuming the port-specific theme draws focus rings, this test draws focus rings around editable multiline text in vertical writing mode.
</div>
</body>
</html>




layer at (0,0) size 800x600
  RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
  RenderBlock {HTML} at (0,0) size 800x600
    RenderBody {BODY} at (8,8) size 784x584
      RenderBlock {DIV} at (0,0) size 160x160
        RenderText {#text} at (0,0) size 154x160
          text run at (0,0) width 130: "Assuming the port-"
          text run at (22,0) width 140: "specific theme draws"
          text run at (22,140) width 4: " "
          text run at (44,0) width 132: "focus rings, this test"
          text run at (44,132) width 4: " "
          text run at (66,0) width 119: "draws focus rings"
          text run at (66,119) width 4: " "
          text run at (88,0) width 107: "around editable"
          text run at (88,107) width 4: " "
          text run at (110,0) width 159: "multiline text in vertical"
          text run at (110,159) width 1: " "
          text run at (132,0) width 94: "writing mode."
caret: position 1 of child 0 {#text} of child 1 {DIV} of body



2011-08-30  Kulanthaivel Palanichamy  <kulanthaivel@codeaurora.org>

        Focus ring is rendered incorrectly for a block with -webkit-writing-mode
        https://bugs.webkit.org/show_bug.cgi?id=62915

        Reviewed by NOBODY (OOPS!).

        RenderBlock::addFocusRingRects() should consider physical box position and
        dimension instead of logical values for focus ring rects calculation.

        Test: fast/css/focus-ring-multiline-writingmode-vertical.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addFocusRingRects):

2011-08-29  John Bauman  <jbauman@chromium.org>

        Speed up texImage from BGRA




    if (!hasOverflowClip() && !hasControlClip()) {
        for (RootInlineBox* curr = firstRootBox(); curr; curr = curr->nextRootBox()) {
            LayoutUnit top = max(curr->lineTop(), static_cast<LayoutUnit>(curr->top()));
            LayoutUnit bottom = min(curr->lineBottom(), static_cast<LayoutUnit>(curr->top() + curr->height()));
            LayoutRect rect(additionalOffset.x() + curr->x(), additionalOffset.y() + top, curr->width(), bottom - top);
            if (!rect.isEmpty())
                rects.append(rect);
        }
- 

Return to Bug 62915

Lines 6020-6028 void RenderBlock::addFocusRingRects(Vector<LayoutRect>& rects, const LayoutPoint a/Source/WebCore/rendering/RenderBlock.cpp_sec1
- a/Source/WebCore/rendering/RenderBlock.cpp -4 / +3 lines
6020		6020
6021	if (!hasOverflowClip() && !hasControlClip()) {	6021	if (!hasOverflowClip() && !hasControlClip()) {
6022	for (RootInlineBox* curr = firstRootBox(); curr; curr = curr->nextRootBox()) {	6022	for (RootInlineBox* curr = firstRootBox(); curr; curr = curr->nextRootBox()) {
6023	LayoutUnit top = max(curr->lineTop(), curr->logicalTop());	6023	LayoutUnit top = max(curr->lineTop(), static_cast<LayoutUnit>(curr->top()));
6024	LayoutUnit bottom = min(curr->lineBottom(), curr->logicalTop() + curr->logicalHeight());	6024	LayoutUnit bottom = min(curr->lineBottom(), static_cast<LayoutUnit>(curr->top() + curr->height()));
6025	LayoutRect rect(additionalOffset.x() + curr->x(), additionalOffset.y() + top, curr->logicalWidth(), bottom - top);	6025	LayoutRect rect(additionalOffset.x() + curr->x(), additionalOffset.y() + top, curr->width(), bottom - top);
6026	if (!rect.isEmpty())	6026	if (!rect.isEmpty())
6027	rects.append(rect);	6027	rects.append(rect);
6028	}	6028	}
6029	-

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +11 lines
		1	2011-08-30 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>
		2
		3	Focus ring is rendered incorrectly for a block with -webkit-writing-mode
		4	https://bugs.webkit.org/show_bug.cgi?id=62915
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	* fast/css/focus-ring-multiline-writingmode-vertical.html: Added.
		9	* platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Added.
		10	* platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Added.
		11
1	2011-08-29 Kenji Imasaki <imasaki@chromium.org>	12	2011-08-29 Kenji Imasaki <imasaki@chromium.org>
2		13
3	[Chromium] Added new rebaselines for media/media-document-audio-repaint.	14	[Chromium] Added new rebaselines for media/media-document-audio-repaint.

Line 0 a/LayoutTests/fast/css/focus-ring-multiline-writingmode-vertical.html_sec1
- a/LayoutTests/fast/css/focus-ring-multiline-writingmode-vertical.html +16 lines
	1	<html>
	2	<head>
	3	<script>
	4	window.onload = function()
	5	{
	6	document.getElementById("multiline").focus();
	7	}
	8	</script>
	9	</head>
	10	<body>
	11	<div id="multiline" style="-webkit-writing-mode: vertical-rl; width: 10em; height: 10em;" contenteditable>
	12	Assuming the port-specific theme draws focus rings, this test draws focus rings around editable multiline text in vertical writing mode.
	13	</div>
	14	</body>
	15	</html>
	16

Line 0 a/LayoutTests/platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt_sec1
- a/LayoutTests/platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt +20 lines
	1	layer at (0,0) size 800x600
	2	RenderView at (0,0) size 800x600
	3	layer at (0,0) size 800x600
	4	RenderBlock {HTML} at (0,0) size 800x600
	5	RenderBody {BODY} at (8,8) size 784x584
	6	RenderBlock {DIV} at (0,0) size 160x160
	7	RenderText {#text} at (0,0) size 154x160
	8	text run at (0,0) width 130: "Assuming the port-"
	9	text run at (22,0) width 140: "specific theme draws"
	10	text run at (22,140) width 4: " "
	11	text run at (44,0) width 132: "focus rings, this test"
	12	text run at (44,132) width 4: " "
	13	text run at (66,0) width 119: "draws focus rings"
	14	text run at (66,119) width 4: " "
	15	text run at (88,0) width 107: "around editable"
	16	text run at (88,107) width 4: " "
	17	text run at (110,0) width 159: "multiline text in vertical"
	18	text run at (110,159) width 1: " "
	19	text run at (132,0) width 94: "writing mode."
	20	caret: position 1 of child 0 {#text} of child 1 {DIV} of body

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +15 lines
		1	2011-08-30 Kulanthaivel Palanichamy <kulanthaivel@codeaurora.org>
		2
		3	Focus ring is rendered incorrectly for a block with -webkit-writing-mode
		4	https://bugs.webkit.org/show_bug.cgi?id=62915
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	RenderBlock::addFocusRingRects() should consider physical box position and
		9	dimension instead of logical values for focus ring rects calculation.
		10
		11	Test: fast/css/focus-ring-multiline-writingmode-vertical.html
		12
		13	* rendering/RenderBlock.cpp:
		14	(WebCore::RenderBlock::addFocusRingRects):
		15
1	2011-08-29 John Bauman <jbauman@chromium.org>	16	2011-08-29 John Bauman <jbauman@chromium.org>
2		17
3	Speed up texImage from BGRA	18	Speed up texImage from BGRA